acp: add native Zephyr drivers for AMD ACP 7.0#10571
acp: add native Zephyr drivers for AMD ACP 7.0#10571Sivasubramanian678 wants to merge 5 commits intothesofproject:mainfrom
Conversation
This commit adds support for ACP 7.0 native zephyr and also adds acp_7_0
in zephyr build script.
Changes include:
- Add changes in platform-specific files for ACP 7.0 for
native zephyr support
- Add ACP 7.0 in cmakelist under zephyr
- Remove DMA based scheduling from kconfig for
ACP 7.0
- Add acp_7_0 support in zephyr build script
- Add xtensa files idma.h,xtensa-types.h and
xt_externalregisters.h
- Add UINT32_C macro fallback for stdint.h
compatibility in tie.h
- Replace addi.a with addi in tie-asm.h for Xtensa
assembler compatibility.
This enables native Zephyr-based SOF support for AMD ACP 7.0
hardware platform.
Signed-off-by: Sivasubramanian <sravisar@amd.com>
Remove legacy chip_offset_byte.h and chip_register.h header files as they are no longer needed with native Zephyr driver support for the 7_0 platform. Signed-off-by: Sivasubramanian <sravisar@amd.com>
Disable COMP_MUX and PROBE and remove AMD_BINARY_BUILD. Signed-off-by: Sivasubramanian <sravisar@amd.com>
This adds SoundWire DAI support for ACP 7.0 native zephyr. Signed-off-by: Sivasubramanian <sravisar@amd.com>
This adds changes for ACP 6.0 non native zephyr support. Signed-off-by: Sivasubramanian <sravisar@amd.com>
Sivasubramanian678
requested review from
RanderWang,
abonislawski,
bhiregoudar,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
lyakh,
mmaka1,
pblaszko,
plbossart,
sunilkumardommati and
tmleman
as code owners
|
Can one of the admins verify this patch?
|
|
Dependency: This PR depends on zephyrproject-rtos/zephyr#104450 for native Zephyr ACP 7.0 driver enablement. |
|
test this please |
|
@Sivasubramanian678 can you check the CI, looks like we have some build errors... |
The error that is happening in CI test is because of the dependency of Zephyr PR - zephyrproject-rtos/zephyr#104450 .In that PR we have included the required macro. I think till that PR gets merged CI test won't pass. Is there anyway to avoid this CI test failure? |
No, probably best we get the Zephyr PR merged 1st and then we can rerun CI to make sure all is good. |
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
some parts of this PR also affect non-AMD platforms, just need to be aware and check potential side-effects
|
|
||
| /* imx currently has no IRQ driver in Zephyr so we force to xtos IRQ */ | ||
| #if defined(CONFIG_AMD) | ||
| #ifndef CONFIG_ZEPHYR_NATIVE_DRIVERS |
There was a problem hiding this comment.
so this now will be enabled for all builds that don't set CONFIG_ZEPHYR_NATIVE_DRIVERS
| * to native drivers. | ||
| */ | ||
| #if defined(CONFIG_AMD) | ||
| #ifndef CONFIG_ZEPHYR_NATIVE_DRIVERS |
There was a problem hiding this comment.
this potentially affects other platforms too
There was a problem hiding this comment.
this potentially affects other platforms too
...although currently apparently only AMD has CONFIG_ZEPHYR_NATIVE_DRIVERS=n
There was a problem hiding this comment.
This change was done to maintain backward compatibility for previous generation AMD platform. We will check whether we can update the previous generation platform to native zephyr to avoid this change.
5 participants
This PR adds native Zephyr support for AMD Audio Co-Processor (ACP) version 7.0 for handling Sound Wire IO.